Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule/name docs #1061

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix rule/name docs #1061

merged 1 commit into from
Aug 12, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

github-actions[bot]
github-actions bot reviewed Aug 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.64.0-3-gaf8416b
Number of rules parsed 4
Number of rules checked 0
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@github-actions GitHub Actions
Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   38.34m ± 1%   38.35m ± 5%       ~ (p=0.853 n=10)
CheckRules-4     8.515 ± 2%    8.494 ± 2%       ~ (p=0.739 n=10)
geomean         571.4m        570.8m       -0.11%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.38Mi ± 0%   27.38Mi ± 0%       ~ (p=0.739 n=10)
CheckRules-4    940.4Mi ± 0%   942.1Mi ± 0%       ~ (p=0.218 n=10)
geomean         160.5Mi        160.6Mi       +0.09%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.6k ± 0%   131.6k ± 0%       ~ (p=0.562 n=10)
CheckRules-4    13.97M ± 0%   13.98M ± 0%       ~ (p=0.247 n=10)
geomean         1.356M        1.356M       +0.03%

@prymitive prymitive merged commit 458f772 into main Aug 12, 2024
20 checks passed
@prymitive prymitive deleted the name branch August 12, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prymitive